)]}'
{
  "commit": "ce1584d1f0fa60981d06c477541c6e81371314a8",
  "tree": "e6fd2de9d96e6f4565396e04b31b60236af1047c",
  "parents": [
    "1302a4bac66fbb64b642aba8f4e2e7d06500c7f4"
  ],
  "author": {
    "name": "Ben Clayton",
    "email": "bclayton@google.com",
    "time": "Fri Sep 25 18:13:42 2020 +0100"
  },
  "committer": {
    "name": "Ben Clayton",
    "email": "bclayton@google.com",
    "time": "Tue Sep 29 10:14:43 2020 +0000"
  },
  "message": "Vulkan/Debug: Overhaul Values / Variables\n\n`Value` had a number of methods that were never used (like `set()`), so just remove them.\nRemove `Type`, this was also unused, and was unncessarily complex to maintain.\n\nAdd `Variables` interface that allows other composite value implementations that are not `VariableContainer`.\n\nBreak the inheritance of `VariableContainer` from `Value`, as this forces pointer casting and doesn\u0027t work with the `Variables` interface.\n\nAdd `Struct` which is an implementation of `Value` that implements the new `children()` method to return the provided `Variables`.\n\nSets the groundwork for the overhauled debugger implementation.\n\nNote: The changes to `SpirvShaderDebugger.cpp` are a least-effort set of changes to make things compile.\nA significant amount of this file (along with these changes) will be reimplemented in a followup change.\n\nBug: b/145351270\nChange-Id: Ic3a641a246737b1f82c786fa8c1ec75700b2a71a\nReviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/48693\nKokoro-Result: kokoro \u003cnoreply+kokoro@google.com\u003e\nTested-by: Ben Clayton \u003cbclayton@google.com\u003e\nReviewed-by: Antonio Maiorano \u003camaiorano@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1608bc5719361638a264912dad9673aa58d8dccc",
      "old_mode": 33188,
      "old_path": "src/Pipeline/SpirvShaderDebugger.cpp",
      "new_id": "432b9371719ea2e8443fb36a062b94ad65228f91",
      "new_mode": 33188,
      "new_path": "src/Pipeline/SpirvShaderDebugger.cpp"
    },
    {
      "type": "modify",
      "old_id": "5128fe90e7ca8d64c6a4f3446507c6886b253420",
      "old_mode": 33188,
      "old_path": "src/Vulkan/CMakeLists.txt",
      "new_id": "4652917f258f6a5c1b3d1b756932e5006d7414c0",
      "new_mode": 33188,
      "new_path": "src/Vulkan/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "ccee98f30c2d861128a726af86b71317605c5d56",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Context.cpp",
      "new_id": "b311e2f34dfab0a758d63eecf96c5e7d84b0164c",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/Context.cpp"
    },
    {
      "type": "modify",
      "old_id": "832c9c435977e7eeb17d7f0f80bb55fe9c07bb88",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Context.hpp",
      "new_id": "64e7e5569c9ae260647637077169880d42aa0339",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/Context.hpp"
    },
    {
      "type": "modify",
      "old_id": "b6d4443bc5b30a2e965d046a738f93eb1d374c5f",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Server.cpp",
      "new_id": "9dd05ce74f28fce769b30fb81d5d3146a24e2872",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/Server.cpp"
    },
    {
      "type": "delete",
      "old_id": "c3e0ab47c24e36bd7c369d7208488c8ba4928aa9",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Type.cpp",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "c3c3d4ba657e66d047fe80ed31f75638e157942d",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Type.hpp",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "637d03c11de7dbd6b2917568b1eb94f6473c5963",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/TypeOf.cpp"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "3c5a8c57ad3286a2af4d3910418f62ad92604ae9",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/TypeOf.hpp"
    },
    {
      "type": "modify",
      "old_id": "49420b467e8be23183cf97619b7c9f1afb78985f",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Value.cpp",
      "new_id": "8ff221dc855d0eed4bd3653813c20cd57e2632ac",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/Value.cpp"
    },
    {
      "type": "modify",
      "old_id": "15105c276bcd2ad1c54cad91ae92d4dc9a9420c6",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Value.hpp",
      "new_id": "6deb3d6001f725df5c74079ccabfae1c7e1b1944",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/Value.hpp"
    },
    {
      "type": "modify",
      "old_id": "8145e01419fa2bdeace8b3dfa9072ae775b3a292",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Variable.cpp",
      "new_id": "abade64a1d92f0dbce2552be126d6881fa27af22",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/Variable.cpp"
    },
    {
      "type": "modify",
      "old_id": "8818b5babb4dec9c39620e5c6d533ef29a2009a0",
      "old_mode": 33188,
      "old_path": "src/Vulkan/Debug/Variable.hpp",
      "new_id": "cbc8d51d162641a2aea8a08603ad9d76e3908eec",
      "new_mode": 33188,
      "new_path": "src/Vulkan/Debug/Variable.hpp"
    }
  ]
}