CommandPool reset and trim
Implemented vkResetCommandPool and vkTrimCommandPool.
The reset command out all command buffers in the command
pool back to the initial state. It also frees up the entire pool.
The trim command is a potential future memory usage optimization.
It is currently a noop.
Passes a few tests in dEQP-VK.api.command_buffers.
Bug b/119827933
Change-Id: Ic974f63a8dfca014462ac904218b9dcc3035fc8a
Reviewed-on: https://swiftshader-review.googlesource.com/c/24370
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
diff --git a/src/Vulkan/VkCommandPool.cpp b/src/Vulkan/VkCommandPool.cpp
index 821d4fb..85c5738 100644
--- a/src/Vulkan/VkCommandPool.cpp
+++ b/src/Vulkan/VkCommandPool.cpp
@@ -13,6 +13,7 @@
// limitations under the License.
#include "VkCommandPool.hpp"
+#include "VkCommandBuffer.hpp"
#include "VkDestroy.h"
#include <algorithm>
@@ -79,4 +80,28 @@
}
}
+VkResult CommandPool::reset(VkCommandPoolResetFlags flags)
+{
+ // According the Vulkan 1.1 spec:
+ // "All command buffers that have been allocated from
+ // the command pool are put in the initial state."
+ for(auto commandBuffer : *commandBuffers)
+ {
+ Cast(commandBuffer)->reset(flags);
+ }
+
+ // According the Vulkan 1.1 spec:
+ // "Resetting a command pool recycles all of the
+ // resources from all of the command buffers allocated
+ // from the command pool back to the command pool."
+ commandBuffers->clear();
+
+ return VK_SUCCESS;
+}
+
+void CommandPool::trim(VkCommandPoolTrimFlags flags)
+{
+ // TODO (b/119827933): Optimize memory usage here
+}
+
} // namespace vk
