commit c9ec5793338dd62d84246f3143fd7ffc70cbc89b
author Jan Voung <jvoung@chromium.org> Thu Feb 05 17:31:28 2015 -0800
committer Jan Voung <jvoung@chromium.org> Thu Feb 05 17:31:28 2015 -0800
tree 764bc3093e5ae678dc23eedaaa014d2ed910d538
parent 7ad1bed99d058199a3ba246a5383458518596fbc

Convert a few getName() methods to return a const string ref.

Followup to a previous code review.
Saves 2KB from the minimal build =)

BUG=none
R=stichnot@chromium.org

Review URL: https://codereview.chromium.org/904783002

src/IceELFObjectWriter.cpp

diff --git a/src/IceELFObjectWriter.cpp b/src/IceELFObjectWriter.cpp
index 2d11eb3..bd0d089 100644
--- a/src/IceELFObjectWriter.cpp
+++ b/src/IceELFObjectWriter.cpp
@@ -541,7 +541,7 @@
 void ELFObjectWriter::setUndefinedSyms(const ConstantList &UndefSyms) {
   for (const Constant *S : UndefSyms) {
     const auto Sym = llvm::cast<ConstantRelocatable>(S);
-    IceString Name = Sym->getName();
+    const IceString &Name = Sym->getName();
     assert(Sym->getOffset() == 0);
     assert(Sym->getSuppressMangling());
     SymTab->noteUndefinedSym(Name, NullSection);