commit c710de9749367f4aad88d3b030172322919c85f8
author Geoff Lang <geofflang@google.com> Thu Sep 23 10:10:03 2021 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 23 14:46:22 2021 +0000
tree 6f1cc9090f9a1d44225e637c60836ca8487e8e22
parent 4e3812937c5f2835c861a3e578d9f063b88bbfe3

Only use -Wno-shadow on clang builds.

SwiftShader is also built in msvc where this flag does not exist.

Bug: chromium:794619
Change-Id: I3ac66166eb4e09a9e923281d1d1e75314097e808
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/57368
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Commit-Queue: Geoff Lang <geofflang@google.com>
Tested-by: Geoff Lang <geofflang@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 37f7de1..53b1d82 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -15,10 +15,14 @@
 import("src/Reactor/reactor.gni")
 
 config("swiftshader_config") {
-  cflags = [ "-Wno-shadow" ]
+  cflags = []
   defines = []
   asmflags = []
 
+  if (is_clang) {
+    cflags += [ "-Wno-shadow" ]
+  }
+
   if (!is_debug) {
     defines += [ "ANGLE_DISABLE_TRACE" ]
   }