SpirvShader: Implement OpSelect
Bug: b/126873455
Change-Id: I5df5206cb3743dd7b36d4ad521f9e9ddf81ae638
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26168
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
diff --git a/src/Pipeline/SpirvShader.cpp b/src/Pipeline/SpirvShader.cpp
index 1b3e297..3b17a07 100644
--- a/src/Pipeline/SpirvShader.cpp
+++ b/src/Pipeline/SpirvShader.cpp
@@ -289,6 +289,7 @@
case spv::OpConvertSToF:
case spv::OpConvertUToF:
case spv::OpBitcast:
+ case spv::OpSelect:
// Instructions that yield an intermediate value
{
TypeID typeId = insn.word(1);
@@ -1005,6 +1006,10 @@
EmitDot(insn, routine);
break;
+ case spv::OpSelect:
+ EmitSelect(insn, routine);
+ break;
+
default:
UNIMPLEMENTED(OpcodeName(insn.opcode()).c_str());
break;
@@ -1470,6 +1475,24 @@
dst.emplace(0, result);
}
+ void SpirvShader::EmitSelect(InsnIterator insn, SpirvRoutine *routine) const
+ {
+ auto &type = getType(insn.word(1));
+ auto &dst = routine->createIntermediate(insn.word(2), type.sizeInComponents);
+ auto srcCond = GenericValue(this, routine, insn.word(3));
+ auto srcLHS = GenericValue(this, routine, insn.word(4));
+ auto srcRHS = GenericValue(this, routine, insn.word(5));
+
+ for (auto i = 0u; i < type.sizeInComponents; i++)
+ {
+ auto cond = As<SIMD::Int>(srcCond[i]);
+ auto lhs = srcLHS[i];
+ auto rhs = srcRHS[i];
+ auto out = (cond & As<Int4>(lhs)) | (~cond & As<Int4>(rhs)); // FIXME: IfThenElse()
+ dst.emplace(i, As<SIMD::Float>(out));
+ }
+ }
+
void SpirvShader::emitEpilog(SpirvRoutine *routine) const
{
for (auto insn : *this)
diff --git a/src/Pipeline/SpirvShader.hpp b/src/Pipeline/SpirvShader.hpp
index 76400c0..f9e19d6 100644
--- a/src/Pipeline/SpirvShader.hpp
+++ b/src/Pipeline/SpirvShader.hpp
@@ -410,6 +410,7 @@
void EmitUnaryOp(InsnIterator insn, SpirvRoutine *routine) const;
void EmitBinaryOp(InsnIterator insn, SpirvRoutine *routine) const;
void EmitDot(InsnIterator insn, SpirvRoutine *routine) const;
+ void EmitSelect(InsnIterator insn, SpirvRoutine *routine) const;
// OpcodeName returns the name of the opcode op.
// If NDEBUG is defined, then OpcodeName will only return the numerical code.
