commit bbb8fc17be40e0bd42d6296dc47295c10f437373
author Alexis Hetu <sugoi@google.com> Tue Nov 21 12:39:41 2017 -0500
committer Alexis Hétu <sugoi@google.com> Wed Nov 22 14:51:00 2017 +0000
tree d898e6f9b63caeec900d7eba0f3026096ecd01e9
parent 848aa7fc4f1c71e3d5bdb896c249461d495b248d

glCompressedTexSub* validation fixes

- Added imageSize validation checks
- Added ETC2/EAC specific validations

Change-Id: I8671b08caecb7aaff0b42d6843d31738b54d0f5a
Reviewed-on: https://swiftshader-review.googlesource.com/14088
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

src/OpenGL/libGLESv2/libGLESv2.cpp

diff --git a/src/OpenGL/libGLESv2/libGLESv2.cpp b/src/OpenGL/libGLESv2/libGLESv2.cpp
index 2ba9176..2ad5717 100644
--- a/src/OpenGL/libGLESv2/libGLESv2.cpp
+++ b/src/OpenGL/libGLESv2/libGLESv2.cpp
@@ -947,9 +947,9 @@
 		return error(validationError);
 	}
 
-	if(width == 0 || height == 0)
+	if(imageSize != egl::ComputeCompressedSize(width, height, format))
 	{
-		return;
+		return error(GL_INVALID_VALUE);
 	}
 
 	es2::Context *context = es2::getContext();
@@ -6578,9 +6578,9 @@
 		return error(validationError);
 	}
 
-	if(width == 0 || height == 0 || depth == 0)
+	if(imageSize != egl::ComputeCompressedSize(width, height, format) * depth)
 	{
-		return;
+		return error(GL_INVALID_VALUE);
 	}
 
 	es2::Context *context = es2::getContext();