commit b7126bab3a192d7f7f86f2ab6975fc911f85858b
author Nicolas Capens <capn@google.com> Mon May 10 11:26:02 2021 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 11 18:05:54 2022 +0000
tree 4ad217e84f6a2f8040680a0ea8a7b59db31293ea
parent e0a1188d76522d47c84c71a42b767ac19d3c7893

Fully enable MemorySanitizer instrumentation for GN builds

MemorySanitizer instrumentation was previously only enabled for select
routines. Specifically pixel routines were still using the workaround
of unpoisoning all memory writes. This change universally enables proper
instrumentation for GN builds.

Bug: b/188205704
Change-Id: I207acbba4675000370befd86e56e8cf5b7c481fe
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/54128
Tested-by: Nicolas Capens <nicolascapens@google.com>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

src/Reactor/BUILD.gn

diff --git a/src/Reactor/BUILD.gn b/src/Reactor/BUILD.gn
index 676f99f..86f4bc6 100644
--- a/src/Reactor/BUILD.gn
+++ b/src/Reactor/BUILD.gn
@@ -27,6 +27,11 @@
     ]
   } else {
     cflags = [ "-Wno-unused-local-typedef" ]
+    defines = [
+      # Enable instrumentation of Reactor routines for MemorySanitizer builds (LLVM backend).
+      # TODO(b/155148722): Remove when unconditionally instrumenting for all build systems.
+      "REACTOR_ENABLE_MEMORY_SANITIZER_INSTRUMENTATION=1",
+    ]
   }
 }