commit b6c96af1e5f019374ab93b2b66fbf79247d24660
author Karl Schimpf <kschimpf@google.com> Mon Nov 17 10:58:39 2014 -0800
committer Karl Schimpf <kschimpf@google.com> Mon Nov 17 10:58:39 2014 -0800
tree 52190a11824e4c78d1b03cce7cad595c1715bd3a
parent 70d0a054b3a2ed6ee49b2bf5d94cf52d79bbb1b9

Turn off dump/emit routines when building minimal subzero.

Remove the dump/emit routines when ALLOW_DUMP=0. Also fixes some
verbosity messages to not print if ALLOW_DUMP=0. Note: emit routines
needed for emitIAS are not turned off.

BUG=None
R=stichnot@chromium.org

Review URL: https://codereview.chromium.org/686913005

src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp
index cd40e09..82d20b4 100644
--- a/src/IceTargetLoweringX8632.cpp
+++ b/src/IceTargetLoweringX8632.cpp
@@ -898,7 +898,7 @@
     Var->setStackOffset(Linked->getStackOffset());
   }
 
-  if (Func->getContext()->isVerbose(IceV_Frame)) {
+  if (ALLOW_DUMP && Func->getContext()->isVerbose(IceV_Frame)) {
     Ostream &Str = Func->getContext()->getStrDump();
 
     Str << "Stack layout:\n";
@@ -996,6 +996,7 @@
 const char *PoolTypeConverter<double>::PrintfString = "0x%llx";
 
 template <typename T> void TargetX8632::emitConstantPool() const {
+  // Note: Still used by emit IAS.
   Ostream &Str = Ctx->getStrEmit();
   Type Ty = T::Ty;
   SizeT Align = typeAlignInBytes(Ty);
@@ -1024,6 +1025,7 @@
 }
 
 void TargetX8632::emitConstants() const {
+  // Note: Still used by emit IAS.
   emitConstantPool<PoolTypeConverter<float> >();
   emitConstantPool<PoolTypeConverter<double> >();
 
@@ -3561,6 +3563,8 @@
 void dumpAddressOpt(const Cfg *Func, const Variable *Base,
                     const Variable *Index, uint16_t Shift, int32_t Offset,
                     const Inst *Reason) {
+  if (!ALLOW_DUMP)
+    return;
   if (!Func->getContext()->isVerbose(IceV_AddrOpt))
     return;
   Ostream &Str = Func->getContext()->getStrDump();
@@ -4528,6 +4532,8 @@
 }
 
 template <> void ConstantInteger32::emit(GlobalContext *Ctx) const {
+  if (!ALLOW_DUMP)
+    return;
   Ostream &Str = Ctx->getStrEmit();
   Str << "$" << (int32_t)getValue();
 }
@@ -4537,11 +4543,15 @@
 }
 
 template <> void ConstantFloat::emit(GlobalContext *Ctx) const {
+  if (!ALLOW_DUMP)
+    return;
   Ostream &Str = Ctx->getStrEmit();
   Str << ".L$" << IceType_f32 << "$" << getPoolEntryID();
 }
 
 template <> void ConstantDouble::emit(GlobalContext *Ctx) const {
+  if (!ALLOW_DUMP)
+    return;
   Ostream &Str = Ctx->getStrEmit();
   Str << ".L$" << IceType_f64 << "$" << getPoolEntryID();
 }