tree 72e554f42f303e8842e54d01fecfff2f67ecd607
parent 51b2800bb317d9ab6026e6123c62f013dd5cf5e4
author Nicolas Capens <capn@google.com> 1583475121 -0500
committer Nicolas Capens <nicolascapens@google.com> 1583508068 +0000

Explicitly compile with warnings-as-errors

This is a partial revert of https://swiftshader-review.googlesource.com/c/SwiftShader/+/40788
where .c files were renamed to .cpp to avoid a warning treated as error:
command line option ‘-fno-operator-names’ is valid for C++/ObjC++ but not for C [-Werror]
This appears to have caused macOS linker issues: chromium:1059196

Instead, explicitly add the flag to compile with warnings-as-errors
(when enabled) for code that is actively maintained by us, and make
Subzero's legacy LLVM dependencies a separate library compiled without
warnings-as-errors.

Also revert CMakeSettings.json changes that were inadvertently committed.

Bug: b/141361933
Bug: chromium:1059196
Change-Id: I27dd57d954a413a710613b0bfa2e69bd5242853a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41968
Reviewed-by: Marc-Antoine Desroches <madesroches@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>