commit aa2666f9414d96a3aadbadac1023b0222719ea50
author Alexis Hetu <sugoi@google.com> Mon Sep 25 15:56:44 2017 -0400
committer Alexis Hétu <sugoi@google.com> Tue Sep 26 17:08:49 2017 +0000
tree 98491585c435ed141f1f6d206feddd15316c9cd6
parent aa8239a50a7266967667c63041f6aaa1f9ff5d93

Properly initializing image's memory

MSAN detected uninitialized memory which caused many test failures.
This can be easily fixed by zeroing out the memory before calling
XCreateImage.

Change-Id: I913c818ef38446055af7fd6aa885028e5f3f8bfb
Reviewed-on: https://swiftshader-review.googlesource.com/12388
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

src/Main/FrameBufferX11.cpp

diff --git a/src/Main/FrameBufferX11.cpp b/src/Main/FrameBufferX11.cpp
index 36ba38f..2cfda6c 100644
--- a/src/Main/FrameBufferX11.cpp
+++ b/src/Main/FrameBufferX11.cpp
@@ -85,8 +85,11 @@
 
 		if(!mit_shm)
 		{
-			buffer = new char[width * height * 4];
-			x_image = libX11->XCreateImage(x_display, visual, depth, ZPixmap, 0, buffer, width, height, 32, width * 4);
+			int bytes_per_line = width * 4;
+			int bytes_per_image = height * bytes_per_line;
+			buffer = new char[bytes_per_image];
+			memset(buffer, 0, bytes_per_image);
+			x_image = libX11->XCreateImage(x_display, visual, depth, ZPixmap, 0, buffer, width, height, 32, bytes_per_line);
 		}
 	}