commit a4afa24ff9099d9343f082c5a5a77898aaf98511
author Nico Weber <thakis@chromium.org> Fri Jan 04 15:28:34 2019 -0500
committer Nico Weber <thakis@chromium.org> Mon Jan 07 16:17:07 2019 +0000
tree ec1f776cfc68f36c60792252cbd9dd06584295ba
parent 050698222644f3dd4c022720f8298075763585be

Remove unnecessary ldflags.

The .def file is already in sources, which means GN will already add
this flag automatically (cf `gn help sources`).

No intended behavior change.

Bug: none
Change-Id: Ic8204bbdd9da47f3731d48e62ccfeb880ac9eddc
Reviewed-on: https://swiftshader-review.googlesource.com/c/23528
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Nico Weber <thakis@chromium.org>

src/OpenGL/libEGL/BUILD.gn

diff --git a/src/OpenGL/libEGL/BUILD.gn b/src/OpenGL/libEGL/BUILD.gn
index ab9b6fe..f4c826d 100644
--- a/src/OpenGL/libEGL/BUILD.gn
+++ b/src/OpenGL/libEGL/BUILD.gn
@@ -53,8 +53,8 @@
 
   sources = [
     "../../Common/SharedLibrary.cpp",
-    "../common/debug.cpp",
     "../common/Object.cpp",
+    "../common/debug.cpp",
     "Config.cpp",
     "Display.cpp",
     "Surface.cpp",
@@ -74,8 +74,6 @@
       "IOSurface.framework",
     ]
     ldflags = [ "-Wl,-install_name,@rpath/libswiftshader_libEGL.dylib" ]
-  } else if (is_win) {
-    ldflags = [ "/DEF:" + rebase_path("libGLESv2.def", root_build_dir) ]
   } else if (is_linux) {
     if (use_x11) {
       sources += [ "../../Main/libX11.cpp" ]

src/OpenGL/libGLESv2/BUILD.gn

diff --git a/src/OpenGL/libGLESv2/BUILD.gn b/src/OpenGL/libGLESv2/BUILD.gn
index cf12aaf..789ec35 100644
--- a/src/OpenGL/libGLESv2/BUILD.gn
+++ b/src/OpenGL/libGLESv2/BUILD.gn
@@ -123,13 +123,11 @@
     "libGLESv2.rc",
   ]
 
-  if (is_win) {
-    ldflags = [ "/DEF:" + rebase_path("libGLESv2.def", root_build_dir) ]
-  } else if (is_mac) {
+  if (is_mac) {
     ldflags = [ "-Wl,-install_name,@rpath/libswiftshader_libGLESv2.dylib" ]
   } else if (is_linux) {
-    ldflags =
-        [ "-Wl,--version-script=" + rebase_path("libGLESv2.lds", root_build_dir) ]
+    ldflags = [ "-Wl,--version-script=" +
+                rebase_path("libGLESv2.lds", root_build_dir) ]
   }
 
   configs = [ ":swiftshader_libGLESv2_private_config" ]