commit 9a04c0760fe48d0003ffcc5be13f67ccd924a9a4
author Jim Stichnoth <stichnot@chromium.org> Thu Dec 11 15:51:42 2014 -0800
committer Jim Stichnoth <stichnot@chromium.org> Thu Dec 11 15:51:42 2014 -0800
tree 4449ab701ca5aed3c61a420119e3e668bb2e86e9
parent 639c9217f08d045abc8f87b75eaa31d2e2aa4094

Subzero: Don't store std::string objects inside Variable.

Instead, extend 668a7a333d6ddc3102b5b7c7c07448f6d259113c to include both CfgNode and Variable, keeping a pool of strings in the Cfg.

BUG= none
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/798693003

src/IceInst.cpp

diff --git a/src/IceInst.cpp b/src/IceInst.cpp
index e1b5f43..3e1ecf7 100644
--- a/src/IceInst.cpp
+++ b/src/IceInst.cpp
@@ -361,8 +361,9 @@
 Inst *InstPhi::lower(Cfg *Func) {
   Variable *Dest = getDest();
   assert(Dest);
-  IceString PhiName = Dest->getName() + "_phi";
-  Variable *NewSrc = Func->makeVariable(Dest->getType(), PhiName);
+  Variable *NewSrc = Func->makeVariable(Dest->getType());
+  if (ALLOW_DUMP)
+    NewSrc->setName(Func, Dest->getName(Func) + "_phi");
   this->Dest = NewSrc;
   return InstAssign::create(Func, Dest, NewSrc);
 }