commit 93317ec84443242e2194eb8ac8a1ad052bc3e278
author Ben Clayton <bclayton@google.com> Wed Feb 20 08:53:50 2019 +0000
committer Ben Clayton <bclayton@google.com> Wed Feb 20 15:50:20 2019 +0000
tree 1156817623fe36072220e3f802929d4c3e5ec2a2
parent d66736a818feec225af22c06b347a9bfe450bb33

Silence warnings: Add override to overriden virtual functions

Bug: b/123933266
Change-Id: I3e5f028ab323f361840a6326a1b7834995e8b8e3
Reviewed-on: https://swiftshader-review.googlesource.com/c/25017
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

src/Vulkan/VkCommandBuffer.cpp

diff --git a/src/Vulkan/VkCommandBuffer.cpp b/src/Vulkan/VkCommandBuffer.cpp
index 6c217dd..f659a01 100644
--- a/src/Vulkan/VkCommandBuffer.cpp
+++ b/src/Vulkan/VkCommandBuffer.cpp
@@ -53,7 +53,7 @@
 	}
 
 protected:
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		executionState.renderPass = renderPass;
 		executionState.renderPassFramebuffer = framebuffer;
@@ -77,7 +77,7 @@
 	}
 
 protected:
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		executionState.renderPass->nextSubpass();
 	}
@@ -93,7 +93,7 @@
 	}
 
 protected:
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		executionState.renderPass->end();
 		executionState.renderPass = nullptr;
@@ -112,7 +112,7 @@
 	}
 
 protected:
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		executionState.pipelines[pipelineBindPoint] = Cast(pipeline);
 	}
@@ -129,7 +129,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		executionState.vertexInputBindings[binding] = { buffer, offset };
 	}
@@ -146,7 +146,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		GraphicsPipeline* pipeline = static_cast<GraphicsPipeline*>(
 			executionState.pipelines[VK_PIPELINE_BIND_POINT_GRAPHICS]);
@@ -186,7 +186,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(srcImage)->copyTo(dstImage, region);
 	}
@@ -204,7 +204,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(srcBuffer)->copyTo(Cast(dstBuffer), region);
 	}
@@ -222,7 +222,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(srcImage)->copyTo(dstBuffer, region);
 	}
@@ -240,7 +240,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(dstImage)->copyFrom(srcBuffer, region);
 	}
@@ -258,7 +258,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(dstBuffer)->fill(dstOffset, size, data);
 	}
@@ -277,7 +277,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(dstBuffer)->update(dstOffset, dataSize, pData);
 	}
@@ -296,7 +296,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(image)->clear(color, range);
 	}
@@ -314,7 +314,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(image)->clear(depthStencil, range);
 	}
@@ -332,7 +332,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		executionState.renderPassFramebuffer->clear(attachment, rect);
 	}
@@ -349,7 +349,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(srcImage)->blit(dstImage, region, filter);
 	}
@@ -367,7 +367,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		// This can currently be a noop. The sw::Surface locking/unlocking mechanism used by the renderer already takes care of
 		// making sure the read/writes always happen in order. Eventually, if we remove this synchronization mechanism, we can
@@ -388,7 +388,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(ev)->signal();
 	}
@@ -404,7 +404,7 @@
 	{
 	}
 
-	void play(CommandBuffer::ExecutionState& executionState)
+	void play(CommandBuffer::ExecutionState& executionState) override
 	{
 		Cast(ev)->reset();
 	}