Subzero: Cleanup Inst==>Instr.
In the beginning, Ice::Inst was called IceInst, and patterns like "IceInst *Inst = ..." made perfect sense.
After the Ice:: name change, "Inst *Inst = ..." continued to compile, mostly.
However, shadowing a type name is clumsy and newer code tends to use "Inst *Instr", so we might as well switch all the instances over.
Some are still called "I" and those are left alone.
BUG= none
R=kschimpf@google.com
Review URL: https://codereview.chromium.org/1665423002 .
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index 97b8c34..ed2a907 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -2743,17 +2743,17 @@
Ice::Variable *Dest = (ReturnType == Ice::IceType_void)
? nullptr
: getNextInstVar(ReturnType);
- std::unique_ptr<Ice::InstCall> Inst;
+ std::unique_ptr<Ice::InstCall> Instr;
if (IntrinsicInfo) {
- Inst.reset(Ice::InstIntrinsicCall::create(Func.get(), Params.size(), Dest,
- Callee, IntrinsicInfo->Info));
+ Instr.reset(Ice::InstIntrinsicCall::create(
+ Func.get(), Params.size(), Dest, Callee, IntrinsicInfo->Info));
} else {
- Inst.reset(Ice::InstCall::create(Func.get(), Params.size(), Dest, Callee,
- IsTailCall));
+ Instr.reset(Ice::InstCall::create(Func.get(), Params.size(), Dest, Callee,
+ IsTailCall));
}
for (Ice::Operand *Param : Params)
- Inst->addArg(Param);
- CurrentNode->appendInst(Inst.release());
+ Instr->addArg(Param);
+ CurrentNode->appendInst(Instr.release());
return;
}
case naclbitc::FUNC_CODE_INST_FORWARDTYPEREF: {
