)]}'
{
  "commit": "8c13b2f02094bb3f6c223b8ec02c6f56bb0f748b",
  "tree": "72e554f42f303e8842e54d01fecfff2f67ecd607",
  "parents": [
    "51b2800bb317d9ab6026e6123c62f013dd5cf5e4"
  ],
  "author": {
    "name": "Nicolas Capens",
    "email": "capn@google.com",
    "time": "Fri Mar 06 01:12:01 2020 -0500"
  },
  "committer": {
    "name": "Nicolas Capens",
    "email": "nicolascapens@google.com",
    "time": "Fri Mar 06 15:21:08 2020 +0000"
  },
  "message": "Explicitly compile with warnings-as-errors\n\nThis is a partial revert of https://swiftshader-review.googlesource.com/c/SwiftShader/+/40788\nwhere .c files were renamed to .cpp to avoid a warning treated as error:\ncommand line option ‘-fno-operator-names’ is valid for C++/ObjC++ but not for C [-Werror]\nThis appears to have caused macOS linker issues: chromium:1059196\n\nInstead, explicitly add the flag to compile with warnings-as-errors\n(when enabled) for code that is actively maintained by us, and make\nSubzero\u0027s legacy LLVM dependencies a separate library compiled without\nwarnings-as-errors.\n\nAlso revert CMakeSettings.json changes that were inadvertently committed.\n\nBug: b/141361933\nBug: chromium:1059196\nChange-Id: I27dd57d954a413a710613b0bfa2e69bd5242853a\nReviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41968\nReviewed-by: Marc-Antoine Desroches \u003cmadesroches@google.com\u003e\nReviewed-by: Nicolas Capens \u003cnicolascapens@google.com\u003e\nTested-by: Nicolas Capens \u003cnicolascapens@google.com\u003e\nKokoro-Presubmit: kokoro \u003cnoreply+kokoro@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "aa835b1d5ba68a22600a0f7ccab7a207a84dd8f1",
      "old_mode": 33188,
      "old_path": "CMakeLists.txt",
      "new_id": "7deb25f228a41957cc5d912b62d48aa0c5560a1c",
      "new_mode": 33188,
      "new_path": "CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "ef9b5f56a925aeed16018d54ec40233bcb951ccd",
      "old_mode": 33188,
      "old_path": "CMakeSettings.json",
      "new_id": "c3d2919c77e5ab2682016e81f7f266852edee08e",
      "new_mode": 33188,
      "new_path": "CMakeSettings.json"
    },
    {
      "type": "modify",
      "old_id": "3c2161e8bc1dbb2138084bbf163d9423547020e6",
      "old_mode": 33188,
      "old_path": "src/Reactor/BUILD.gn",
      "new_id": "66b4bf115cf7b2b13bff3bf7fe5df1911ececce8",
      "new_mode": 33188,
      "new_path": "src/Reactor/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "a66b3b284e000bc705ca6c7f4ec60458548d8b98",
      "old_mode": 33188,
      "old_path": "src/Reactor/SubzeroLLVMDependencies.vcxproj",
      "new_id": "38d75984c017c6561548c2af3564efdb7c91b80b",
      "new_mode": 33188,
      "new_path": "src/Reactor/SubzeroLLVMDependencies.vcxproj"
    },
    {
      "type": "modify",
      "old_id": "4f977ded647bf913a5523064336feaac432dddd3",
      "old_mode": 33188,
      "old_path": "src/Reactor/SubzeroLLVMDependencies.vcxproj.filters",
      "new_id": "d3d84e684e3725acb3c5b1e45fcf40d65b55bbe5",
      "new_mode": 33188,
      "new_path": "src/Reactor/SubzeroLLVMDependencies.vcxproj.filters"
    },
    {
      "type": "modify",
      "old_id": "a8c3c4b6a8cff7eec49c26c3b1996a3df9e4cf45",
      "old_mode": 33188,
      "old_path": "third_party/llvm-subzero/Android.bp",
      "new_id": "72c9b3263f27b0378a93be149aa3c8e9b1efbb18",
      "new_mode": 33188,
      "new_path": "third_party/llvm-subzero/Android.bp"
    },
    {
      "type": "rename",
      "old_id": "7967c6c8c99d294b101718d5a9854b101fda3168",
      "old_mode": 33188,
      "old_path": "third_party/llvm-subzero/lib/Support/regcomp.cpp",
      "new_id": "ebde64f9cf7512d2aa3168b66e1fa07c1b4d7823",
      "new_mode": 33188,
      "new_path": "third_party/llvm-subzero/lib/Support/regcomp.c",
      "score": 99
    },
    {
      "type": "rename",
      "old_id": "1d67c9a2b03b172ee2d5d0128bc1f48ac2508638",
      "old_mode": 33188,
      "old_path": "third_party/llvm-subzero/lib/Support/regerror.cpp",
      "new_id": "1d67c9a2b03b172ee2d5d0128bc1f48ac2508638",
      "new_mode": 33188,
      "new_path": "third_party/llvm-subzero/lib/Support/regerror.c",
      "score": 100
    },
    {
      "type": "rename",
      "old_id": "a4896dc0f5409cd0cab0cf101eed4ded29912531",
      "old_mode": 33188,
      "old_path": "third_party/llvm-subzero/lib/Support/regexec.cpp",
      "new_id": "bd5e72d4c522074587a39c5093e65007af660e09",
      "new_mode": 33188,
      "new_path": "third_party/llvm-subzero/lib/Support/regexec.c",
      "score": 97
    },
    {
      "type": "rename",
      "old_id": "dc2b4af90fa746b47974ba12ec24f7b173d132ac",
      "old_mode": 33188,
      "old_path": "third_party/llvm-subzero/lib/Support/regfree.cpp",
      "new_id": "dc2b4af90fa746b47974ba12ec24f7b173d132ac",
      "new_mode": 33188,
      "new_path": "third_party/llvm-subzero/lib/Support/regfree.c",
      "score": 100
    },
    {
      "type": "rename",
      "old_id": "8b68afdf75f16af34a067d9eaa53b60abbc2ba4a",
      "old_mode": 33188,
      "old_path": "third_party/llvm-subzero/lib/Support/regstrlcpy.cpp",
      "new_id": "8b68afdf75f16af34a067d9eaa53b60abbc2ba4a",
      "new_mode": 33188,
      "new_path": "third_party/llvm-subzero/lib/Support/regstrlcpy.c",
      "score": 100
    }
  ]
}