Replace all UNIMPLEMENTED() with UNSUPPORTED() Most cases of UNIMPLEMENTED() are actually for functionality that we do not support, and correctly advertise as such. It's expected to be an application bug if these asserts are hit, and not an indication of something we must still implement to be a compliant Vulkan implementation. This change will be immediately followed up by one which restores UNIMPLEMENTED() where it was used correctly. This two-change approach makes it much easier to see what still needs to get done. Bug: b/131243109 Change-Id: Id09b5de5bc73fabfdc3199dcd3091cb72283be65 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40408 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com>
diff --git a/src/Device/Context.cpp b/src/Device/Context.cpp index 5275e67..1303e4c 100644 --- a/src/Device/Context.cpp +++ b/src/Device/Context.cpp
@@ -43,7 +43,7 @@ case VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN: return polygonModeAware ? (polygonMode == VK_POLYGON_MODE_POINT) : false; default: - UNIMPLEMENTED("topology %d", int(topology)); + UNSUPPORTED("topology %d", int(topology)); } return false; } @@ -62,7 +62,7 @@ case VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN: return polygonModeAware ? (polygonMode == VK_POLYGON_MODE_LINE) : false; default: - UNIMPLEMENTED("topology %d", int(topology)); + UNSUPPORTED("topology %d", int(topology)); } return false; } @@ -80,7 +80,7 @@ case VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN: return polygonModeAware ? (polygonMode == VK_POLYGON_MODE_FILL) : true; default: - UNIMPLEMENTED("topology %d", int(topology)); + UNSUPPORTED("topology %d", int(topology)); } return false; }