tree 406a32ce4ff321f138f68601d2f4727c84c43d0e
parent 856d3c15bbdd07cb87f227f06634ca1334d2a3ca
author Nicolas Capens <capn@google.com> 1627333633 -0400
committer Nicolas Capens <nicolascapens@google.com> 1627929039 +0000

Refactor sample shading state determination

Previously all logic for determining the actual state for sample shading
was near the top of the PixelRoutine::quad() method, with affected
readability. This change makes us handle the case where SampleId or
SamplePosition decorations are present in the fragment shader in the
PixelProcessor class, which overrides sampleShadingEnabled and
minSampleShading, since this is implementation-independent behavior.

The implementation-dependent behavior of doing per-sample shading even
if the effective minSampleShading isn't 1.0, is now handled in the
PixelRoutine constructor. Other invariant state is also determined in
the constructor.

Bug: b/185227903
Bug: b/194521425
Change-Id: I341dde391a41a0d2b454f9dad4180067ad4dc4e3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/56049
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Sean Risser <srisser@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>