tree 5f21e4748efaccb40afeacc83928f58c36f2d68b
parent 0c22767ec4d9f67b72f03c3a0ea1e2080d8a92f4
author Nicolas Capens <capn@google.com> 1631791102 -0400
committer Nicolas Capens <nicolascapens@google.com> 1632159342 +0000

Fix use of deleted shader during compute execution

ComputeProgram::run() uses the `shader` member, which was previously a
weak pointer to a SpirvShader object. If the corresponding shader module
is destroyed, and there is no (more) pipeline cache to hold a shared_ptr
reference to it, we'd access a deleted object.

The `pipelineLayout` member is safe-ish because we explicitly reference
count it in the vk::Pipeline class, since graphics pipelines also use it
to (re)compile routines at draw execution time.

The ComputeProgramKey was modified to use unique integer identifiers
instead of pointers to the shader and pipeline layout. This prevents a
false cache hit when these objects are destroyed and new ones get
allocated at the same address. Note that this means we lose the nice
property of constructing new cache entries only from cache key data,
but this is a better compromise than the previous buggy code.

Bug: b/197982536
Change-Id: Ie75bb0e8df21ad25c2a7fed29adbf086fab072e3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/57168
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>