Subzero: Class definition cleanup.
For consistency, put deleted ctors at the beginning of the class
definition.
If the default copy ctor or assignment operator is not deleted,
and the default implementation is used, leave it commented out to
indicate it is intentional.
Also, fixed one C++11 related TODO.
BUG= none
R=jvoung@chromium.org, kschimpf@google.com
Review URL: https://codereview.chromium.org/656123003
diff --git a/src/IceRNG.h b/src/IceRNG.h
index 9c4eeda..5f862a8 100644
--- a/src/IceRNG.h
+++ b/src/IceRNG.h
@@ -22,14 +22,14 @@
namespace Ice {
class RandomNumberGenerator {
+ RandomNumberGenerator(const RandomNumberGenerator &) = delete;
+ RandomNumberGenerator &operator=(const RandomNumberGenerator &) = delete;
+
public:
RandomNumberGenerator(llvm::StringRef Salt);
uint64_t next(uint64_t Max);
private:
- RandomNumberGenerator(const RandomNumberGenerator &) = delete;
- RandomNumberGenerator &operator=(const RandomNumberGenerator &) = delete;
-
uint64_t State;
};
@@ -37,16 +37,16 @@
// reason for the wrapper class is that we want to keep the
// RandomNumberGenerator interface identical to LLVM's.
class RandomNumberGeneratorWrapper {
+ RandomNumberGeneratorWrapper(const RandomNumberGeneratorWrapper &) = delete;
+ RandomNumberGeneratorWrapper &
+ operator=(const RandomNumberGeneratorWrapper &) = delete;
+
public:
uint64_t next(uint64_t Max) { return RNG.next(Max); }
bool getTrueWithProbability(float Probability);
RandomNumberGeneratorWrapper(RandomNumberGenerator &RNG) : RNG(RNG) {}
private:
- RandomNumberGeneratorWrapper(const RandomNumberGeneratorWrapper &) = delete;
- RandomNumberGeneratorWrapper &
- operator=(const RandomNumberGeneratorWrapper &) = delete;
-
RandomNumberGenerator &RNG;
};
