Remove -Xclang -fuse-init-array from the Android build flags
aosp/1769785 is a SwiftShader-into-AOSP roll which fails to build due to
the build system misinterpreting -msse2 as part of the -Xclang build
flag.
-Xclang -fuse-init-array was needed to prevent a static initialization
order issue in the legacy OpenGL ES code, which affected Android Jelly
Bean. This was added to the build file by
https://swiftshader-review.googlesource.com/c/SwiftShader/+/4271
Vulkan avoids any static data by design, and newer build toolchains seem
to have been unaffected anyway. Also Clang now defaults to
-fuse-init-array: https://reviews.llvm.org/D71393. So we can just remove
this to avoid the current build issue.
Bug: b/25597090
Change-Id: I2da51c5d56364703f6391649494401c2f5d6e362
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/55909
Reviewed-by: Jason Macnak <natsu@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
diff --git a/Android.bp b/Android.bp
index daba41a..b40af64 100644
--- a/Android.bp
+++ b/Android.bp
@@ -57,7 +57,6 @@
gnu_extensions: false,
cflags: [
- "-Xclang", "-fuse-init-array",
"-msse2",
"-Werror",
"-Wwrite-strings",
