tree d49b9169ca2d12e9fbbb443088f16fc02d5060e7
parent 5db06cf1f22bf8e59b3cd5441bfaa860f164ae56
author Alexis Hetu <sugoi@google.com> 1634583917 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> 1634592389 +0000

Fix uninitialized memoryOwner on unused DescriptorSet

In the Renderer, we call DescriptorSet::PrepareForSampling() on all
input descriptors, not only the ones used in the current draw pass.
Because of this, DescriptorSet::PrepareForSampling() might be called
on uninitialized descriptors. Before this CL:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/57889
that memory used to be zeroed out, so that wasn't an issue, but now
the memoryOwner pointer may be used without being initialized. This
CL adds an initialization for the memoryOwner field on structures
which use it (SampledImageDescriptor and StorageImageDescriptor).

Bug: chromium:1260606
Change-Id: I41a02a8b652a48b790d8aacf16fd28d26e527336
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/58308
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Commit-Queue: Alexis Hétu <sugoi@google.com>