)]}'
{
  "commit": "77b43d681f656771a62084aa6223ebe5f9204a95",
  "tree": "0ca517497db4b4e8444b0110c02a7a51d1e23ed7",
  "parents": [
    "5c3720824f2b33ee10790c6259949906672d01ad"
  ],
  "author": {
    "name": "Nicolas Capens",
    "email": "capn@google.com",
    "time": "Thu Mar 12 00:20:00 2020 -0400"
  },
  "committer": {
    "name": "Nicolas Capens",
    "email": "nicolascapens@google.com",
    "time": "Thu Mar 12 15:19:25 2020 +0000"
  },
  "message": "Document single-level YCbCr image assumption\n\nWe currently rely on limiting the mipmap level count of YCbCr images\nand the presence of sampler YCbCr conversion to disable mipmapping.\n\nThis is valid, but fragile. The Vulkan 1.2 spec guarantees that when\nsampler Y\u0027CbCr conversion is used, the image view must have a Y\u0027CbCr\nformat:\n\n\"If the descriptor refers to a sampler that performs Y\u0027CbCr conversion,\n the sampler must only be used to sample the image in the same\n descriptor.\"\n\n\"If the image view is to be used with a sampler which supports sampler\n Y\u0027CbCr conversion, an identically defined object of type\n VkSamplerYcbcrConversion to that used to create the sampler must be\n passed to vkCreateImageView in a VkSamplerYcbcrConversionInfo included\n in the pNext chain of VkImageViewCreateInfo. Conversely, if a\n VkSamplerYcbcrConversion object is passed to vkCreateImageView, an\n identically defined VkSamplerYcbcrConversion object must be used when\n sampling the image.\"\n\n\"maxMipLevels is the maximum number of mipmap levels. maxMipLevels must\n be equal to the number of levels in the complete mipmap chain based on\n the maxExtent.width, maxExtent.height, and maxExtent.depth, except when\n one of the following conditions is true, in which case it may instead\n be 1:\n  * ...\n  * image format is one of those listed in Formats requiring sampler\n    Y′CBCR conversion for VK_IMAGE_ASPECT_COLOR_BIT image views\"\n\nBug: b/151263485\nChange-Id: Ibb8e3fe34ecda04d6fb41308437fa4c66815f1fb\nReviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42228\nPresubmit-Ready: Nicolas Capens \u003cnicolascapens@google.com\u003e\nKokoro-Presubmit: kokoro \u003cnoreply+kokoro@google.com\u003e\nTested-by: Nicolas Capens \u003cnicolascapens@google.com\u003e\nReviewed-by: Alexis Hétu \u003csugoi@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0de505925a36dc355cc1d4f152255874aff5b887",
      "old_mode": 33188,
      "old_path": "src/Pipeline/SpirvShaderSampling.cpp",
      "new_id": "e2cb5b9855f30a3cc7b409c31903150f5414af4f",
      "new_mode": 33188,
      "new_path": "src/Pipeline/SpirvShaderSampling.cpp"
    },
    {
      "type": "modify",
      "old_id": "e50654b7c6d4c45be0bccdd16ee42bfa4568a174",
      "old_mode": 33188,
      "old_path": "src/Vulkan/VkPhysicalDevice.cpp",
      "new_id": "331187a155b6e3bf4d4954adabb5363af66238e6",
      "new_mode": 33188,
      "new_path": "src/Vulkan/VkPhysicalDevice.cpp"
    }
  ]
}