commit 72a8f8dade0acbf4b9d6a57ce955c6c7b34d0581
author Jim Stichnoth <stichnot@chromium.org> Mon Sep 08 17:56:50 2014 -0700
committer Jim Stichnoth <stichnot@chromium.org> Mon Sep 08 17:56:50 2014 -0700
tree 435ded4db9d9b3e215e1a4e60185eb1b656ac2f9
parent f12355ec5d0680048003f88435aa895830df4bf2

Subzero: Make sure alloca with align=0 is handled correctly.

1. Modify dump() to match LLVM.

2. If it weren't for minimum stack alignment, the alignment code would be broken, so add a test in case the alignment code changes.

BUG= none
R=jvoung@chromium.org, kschimpf@google.com

Review URL: https://codereview.chromium.org/557533003

src/IceInst.cpp

diff --git a/src/IceInst.cpp b/src/IceInst.cpp
index cfcaad3..43291ce 100644
--- a/src/IceInst.cpp
+++ b/src/IceInst.cpp
@@ -534,7 +534,8 @@
   dumpDest(Func);
   Str << " = alloca i8, i32 ";
   getSizeInBytes()->dump(Func);
-  Str << ", align " << getAlignInBytes();
+  if (getAlignInBytes())
+    Str << ", align " << getAlignInBytes();
 }
 
 void InstArithmetic::dump(const Cfg *Func) const {

src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp
index 756508e..c3a6e4d 100644
--- a/src/IceTargetLoweringX8632.cpp
+++ b/src/IceTargetLoweringX8632.cpp
@@ -1118,6 +1118,9 @@
   Operand *TotalSize = legalize(Inst->getSizeInBytes());
   Variable *Dest = Inst->getDest();
   uint32_t AlignmentParam = Inst->getAlignInBytes();
+  // For default align=0, set it to the real value 1, to avoid any
+  // bit-manipulation problems below.
+  AlignmentParam = std::max(AlignmentParam, 1u);
 
   // LLVM enforces power of 2 alignment.
   assert((AlignmentParam & (AlignmentParam - 1)) == 0);

tests_lit/llvm2ice_tests/alloc.ll

diff --git a/tests_lit/llvm2ice_tests/alloc.ll b/tests_lit/llvm2ice_tests/alloc.ll
index 80bba30..d690a19 100644
--- a/tests_lit/llvm2ice_tests/alloc.ll
+++ b/tests_lit/llvm2ice_tests/alloc.ll
@@ -104,6 +104,19 @@
 ; CHECK:      mov     dword ptr [esp], eax
 ; CHECK:      call    f2
 
+; Test alloca with default (0) alignment.
+define void @align0(i32 %n) {
+entry:
+  %array = alloca i8, i32 %n
+  %__2 = ptrtoint i8* %array to i32
+  call void @f2(i32 %__2)
+  ret void
+}
+; CHECK-LABEL: align0
+; CHECK: add [[REG:.*]], 15
+; CHECK: and [[REG]], -16
+; CHECK: sub esp, [[REG]]
+
 define void @f2(i32 %ignored) {
 entry:
   ret void