Add missing virtual destructors.
Polymorphic classes should have virtual destructors.
Change-Id: Ia3c8e48b43ff96df9b9db2e4742fabcbd13ee853
Reviewed-on: https://swiftshader-review.googlesource.com/2666
Tested-by: Greg Hartman <ghartman@google.com>
Reviewed-by: Greg Hartman <ghartman@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>
diff --git a/src/OpenGL/compiler/OutputASM.h b/src/OpenGL/compiler/OutputASM.h
index dbfbec4..5cbf4dd 100644
--- a/src/OpenGL/compiler/OutputASM.h
+++ b/src/OpenGL/compiler/OutputASM.h
@@ -89,6 +89,7 @@
{
friend class OutputASM;
public:
+ virtual ~Shader() {};
virtual sw::Shader *getShader() const = 0;
virtual sw::PixelShader *getPixelShader() const;
virtual sw::VertexShader *getVertexShader() const;
diff --git a/src/OpenGL/libEGL/Context.hpp b/src/OpenGL/libEGL/Context.hpp
index b4a811b..01078b4 100644
--- a/src/OpenGL/libEGL/Context.hpp
+++ b/src/OpenGL/libEGL/Context.hpp
@@ -14,6 +14,7 @@
class Context
{
public:
+ virtual ~Context() {};
virtual void destroy() = 0;
virtual void makeCurrent(Surface *surface) = 0;
virtual void bindTexImage(Surface *surface) = 0;
diff --git a/src/Shader/Shader.hpp b/src/Shader/Shader.hpp
index 870f701..898e96e 100644
--- a/src/Shader/Shader.hpp
+++ b/src/Shader/Shader.hpp
@@ -474,7 +474,7 @@
Shader();
- ~Shader();
+ virtual ~Shader();
int getSerialID() const;
size_t getLength() const;