Subzero: Fix asm (non-ELF) output files.
In an earlier version of Subzero, the text output stream object was
stack-allocated within main. A later refactoring moved its allocation
into a helper function, but it was still being stack-allocated, which
was bad when the helper function returned.
This change allocates the object via "new", which fixes that problem,
but reveals another problem: the raw_ostream object for some reason
doesn't finish writing everything to disk and yielding a truncated
output file. This is solved in the style of the ELF streamer, by
using raw_fd_ostream instead.
BUG= none
R=kschimpf@google.com
Review URL: https://codereview.chromium.org/1111603003
diff --git a/src/IceGlobalContext.h b/src/IceGlobalContext.h
index a1fd133..9fb997c 100644
--- a/src/IceGlobalContext.h
+++ b/src/IceGlobalContext.h
@@ -420,8 +420,8 @@
// StrLock is a global lock on the dump and emit output streams.
typedef std::mutex StrLockType;
StrLockType StrLock;
- Ostream *StrDump; // Stream for dumping / diagnostics
- Ostream *StrEmit; // Stream for code emission
+ Ostream *StrDump; // Stream for dumping / diagnostics
+ Ostream *StrEmit; // Stream for code emission
Ostream *StrError; // Stream for logging errors.
ICE_CACHELINE_BOUNDARY;
