)]}'
{
  "commit": "60f543a6f67e3341312b77fd414358f7f020281e",
  "tree": "a342ea510c5d1b2322632af8fbcfa3fd4dc93c3c",
  "parents": [
    "aa46953c1309f380cfb23ca027c5c2a8dfd20914"
  ],
  "author": {
    "name": "Antonio Maiorano",
    "email": "amaiorano@google.com",
    "time": "Wed Feb 10 10:36:50 2021 -0500"
  },
  "committer": {
    "name": "swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Feb 18 14:29:14 2021 +0000"
  },
  "message": "VulkanBenchmarks: add validation layers and load via ICD\n\nIn DEBUG builds, enable validation layers: VK_LAYER_KHRONOS_validation\nand VK_LAYER_LUNARG_standard_validation. Also register the debug utils\nmessenger ext callback for when validation layers report a problem. We\ncan force validation layers in non-DEBUG by defining\nENABLE_VALIDATION_LAYERS to 1.\n\nIn order to be able to use validation layers, load the Vulkan driver via\nICD, rather than directly. To load SwiftShader, generate a temp icd.json\nfile pointing at the driver path, and temporarily set the\nVK_ICD_FILENAMES env var to point at it when we load the ICD. This also\nallows us to load the native GPU driver by defining LOAD_NATIVE_DRIVER\nto 1 (default is 0).\n\nFixed errors reported by enabling validation layers:\n* TriangleSampleTexture had a mismatched binding number for the sampler2D\n* Correctly set memoryTypeIndex for allocations instead of 0\n\nBug: b/176981107\nChange-Id: I3c791086acea048b73d3568d6d7a45d8e0100c17\nReviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52749\nKokoro-Result: kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Alexis Hétu \u003csugoi@google.com\u003e\nTested-by: Antonio Maiorano \u003camaiorano@google.com\u003e\nCommit-Queue: Antonio Maiorano \u003camaiorano@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "88529034b8dae9ad2b4c05c46ec6e0d9a1afc5fc",
      "old_mode": 33188,
      "old_path": "tests/VulkanBenchmarks/ClearImageBenchmarks.cpp",
      "new_id": "72a6db281ee4286d8462b963c912ce7fd7806fa2",
      "new_mode": 33188,
      "new_path": "tests/VulkanBenchmarks/ClearImageBenchmarks.cpp"
    },
    {
      "type": "modify",
      "old_id": "215d3f468a02e7c83fa0fb5f89d42ed0290fd955",
      "old_mode": 33188,
      "old_path": "tests/VulkanBenchmarks/TriangleBenchmarks.cpp",
      "new_id": "905001014f5e3e81c3dd8d13449327c3fdd95402",
      "new_mode": 33188,
      "new_path": "tests/VulkanBenchmarks/TriangleBenchmarks.cpp"
    },
    {
      "type": "modify",
      "old_id": "2e2e29ef99fcd3857f0e41e8c4356cc3ce991a17",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/DrawTester.cpp",
      "new_id": "356c892edb4a2d02a67bee5fdac13fc00c6a87f9",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/DrawTester.cpp"
    },
    {
      "type": "modify",
      "old_id": "431a6c5a727bbf0c7eae46d2e6d76a9993a9911f",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/DrawTester.hpp",
      "new_id": "e380ef2e617f508847745b591c787c985dc90acc",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/DrawTester.hpp"
    },
    {
      "type": "modify",
      "old_id": "ab62a10339c346fe0bc36d55de897fe3dd4f2e01",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/Framebuffer.cpp",
      "new_id": "dd9298a8ea0c7e54e2095e608cf1d9641eef7593",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/Framebuffer.cpp"
    },
    {
      "type": "modify",
      "old_id": "b3d1620b8c5064b3f255bf6496ff6e7ad8f1f500",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/Framebuffer.hpp",
      "new_id": "505eea1e81369cf6f9179f9fb586d86d3dad8d05",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/Framebuffer.hpp"
    },
    {
      "type": "modify",
      "old_id": "0ffc69bd7bafa269103b23ad938bca65b2336ae7",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/Image.cpp",
      "new_id": "c5cbad6609892df1c16beffd6b469e4574acfea2",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/Image.cpp"
    },
    {
      "type": "modify",
      "old_id": "3526ff2fcdedf90011990e4fcb4c99f8a1b0cbc8",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/Image.hpp",
      "new_id": "5bfa863ec7fd19e2389c61c71ebb546587329d1c",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/Image.hpp"
    },
    {
      "type": "modify",
      "old_id": "adfdedb783f062656354dcbe77841b23e8416a3f",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/Util.hpp",
      "new_id": "980c9846b23749c3d221ae6c5cf664343332e533",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/Util.hpp"
    },
    {
      "type": "modify",
      "old_id": "90f2ca0c66873b2f11706991e477037f8413cfd5",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/VulkanTester.cpp",
      "new_id": "e4c05e5ab3f55e359b6f27ac018a61a6cdef634b",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/VulkanTester.cpp"
    },
    {
      "type": "modify",
      "old_id": "89b7d05c62df31a84937c5a0866795fbc9411f4c",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/VulkanTester.hpp",
      "new_id": "044bffc96bef298b06ba4dbacf749ea6085dc2d5",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/VulkanTester.hpp"
    },
    {
      "type": "modify",
      "old_id": "1cfdbe62eece1d82cfa6e5369ed7256c05ca9ace",
      "old_mode": 33188,
      "old_path": "tests/VulkanWrapper/Window.cpp",
      "new_id": "ad29cfcd6896506f11c4d8eecaf5730254bb4360",
      "new_mode": 33188,
      "new_path": "tests/VulkanWrapper/Window.cpp"
    }
  ]
}