)]}'
{
  "commit": "5be09849424d901df56cfacd6f543bb4c6738993",
  "tree": "150ffeee071936a667574fc0609e06c629308a62",
  "parents": [
    "391532fef197ffae899b2819d98fc40c8a394679"
  ],
  "author": {
    "name": "Nicolas Capens",
    "email": "capn@google.com",
    "time": "Wed Oct 02 13:09:25 2019 -0400"
  },
  "committer": {
    "name": "Nicolas Capens",
    "email": "nicolascapens@google.com",
    "time": "Wed Oct 02 21:07:11 2019 +0000"
  },
  "message": "Fix integer overflow in image size calculation\n\nGLsizei is historically defined as a 32-bit signed integer, which is\nnot allowed to be negative. But doing arithmetic with them can lead to\noverflows producing undefined values, including negative ones.\n\nUse size_t instead for these image data size calculations. It\u0027s defined\nas an unsigned integer large enough to fit valid memory buffer sizes.\nIn practice that\u0027s 32-bit on 32-bit platforms, and 64-bit on 64-bit\nones, which is large enough to avoid overflow in the OutOfMemory test.\n\nBug: b/140421004\nChange-Id: Id05dd64d470f579455fdc9925b0ab303ecaf37fb\nReviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36968\nTested-by: Nicolas Capens \u003cnicolascapens@google.com\u003e\nReviewed-by: Alexis Hétu \u003csugoi@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e03abc27e9f469ef0170d9615c7144dcf775679e",
      "old_mode": 33188,
      "old_path": "src/OpenGL/libGLESv2/Context.cpp",
      "new_id": "35ec488bb6c4ddf73214ef641c6ca10708d544e2",
      "new_mode": 33188,
      "new_path": "src/OpenGL/libGLESv2/Context.cpp"
    },
    {
      "type": "modify",
      "old_id": "4b37709e21e20d0f53bf1e34c9a8b4864b5aee54",
      "old_mode": 33188,
      "old_path": "src/OpenGL/libGLESv2/Context.h",
      "new_id": "5eb28b5d8ff5ef0e03121446b23ac308cf7fd664",
      "new_mode": 33188,
      "new_path": "src/OpenGL/libGLESv2/Context.h"
    }
  ]
}
