tree 618d397807e250b79c3176993a60d6c8a6a4accf
parent 9097eeb5359bbbe7e116bfa9233863b411a006d7
author Sean Risser <srisser@google.com> 1570727570 -0400
committer Sean Risser <srisser@google.com> 1571235765 +0000

Fix how we calculate potential overflows with PBOs

We were previously checking if we could read to the end of the last
row in a pixel buffer object without overrunning the buffer. Instead
we need to check if we could read to the last byte defined by the
parameters and state without overrunning the buffer.

Also added a unittest to ensure that we don't reject valid PBO
operations, and do reject invalid PBO operations.

Bug: 140881221
Change-Id: I9b8879f1be30ec4fe6d60fe43f8ff4078f215868
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37228
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Sean Risser <srisser@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>