tree b1ff07d74ba500bee49dbd0fea59426b716a5e74
parent 3429bb56858a1a533b90aa02765c302eae6da62a
author Ben Clayton <bclayton@google.com> 1560167829 +0100
committer Ben Clayton <bclayton@google.com> 1560203387 +0000

ComputeProgram: Remove data field to fix race.

data is the 0th argument to the coroutine.
There's no good reason why this was stored as a field when all other arguments were fetched in ComputeProgram::emit().

Having this as a field caused a data race in the rr::Variable materializing, as the destructor of this field was called outside the reactor mutex.

Test: dEQP-VK.synchronization.internally_synchronized_objects.pipeline_cache_compute
Bug: b/133127573
Change-Id: I44545b71714fdebd8f1150bf7d6325f7d4d4d3eb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32569
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>