|author||David Benjamin <firstname.lastname@example.org>||Fri Nov 03 21:41:48 2023 -0400|
|email@example.com <firstname.lastname@example.org>||Wed Nov 08 01:16:19 2023 +0000|
Fix some more UBSan errors in swiftshader VkPipelineLayout.cpp had a memcpy call that could be passed NULL, 0. Switch to std::copy which avoids this and also a manual sizeof multiplication. VkStructConversion.cpp is a bit more fun. It manually lays out a bunch of arrays in a single structure. Almost all fields in the array provide 8-byte alignment, except for VkPipelineStageFlags. If there are an odd number of VkPipelineStageFlags, subsequent fields become misaligned. This is undefined not only by C/C++ (it is forbidden to cast unaligned pointers), but also Vulkan itself if I'm understanding the spec right: https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#fundamentals-validusage-pointers (Although Vulkan saying it is somewhat redundant because merely having those pointer types in the type signature means you must keep them aligned by C/C++'s rules.) Fix this by rounding all the array sizes up to a multiple of 8. This is a no-op for everything but the VkPipelineStageFlags fields, but I applied it to all fields so it is more obviously correct. The compiler is smart enough to optimize this out per .  https://godbolt.org/z/nfM3Y6xfo Bug: chromium:1394755 Change-Id: I950869e4fed969351ac1aefddd72a898b43cfdc1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/72628 Tested-by: Shahbaz Youssefi <email@example.com> Presubmit-Ready: Shahbaz Youssefi <firstname.lastname@example.org> Commit-Queue: Shahbaz Youssefi <email@example.com> Reviewed-by: Shahbaz Youssefi <firstname.lastname@example.org> Kokoro-Result: kokoro <email@example.com>
SwiftShader[^1] is a high-performance CPU-based implementation[^2] of the Vulkan[^3] 1.3 graphics API. Its goal is to provide hardware independence for advanced 3D graphics.
NOTE: The ANGLE project can be used to achieve a layered implementation[^4] of OpenGL ES 3.1 (aka. “SwANGLE”).
SwiftShader libraries can be built for Windows, Linux, and macOS.
Android and Chrome (OS) build environments are also supported.
cd build cmake .. cmake --build . --parallel ./vk-unittests
Tip: Set the CMAKE_BUILD_PARALLEL_LEVEL environment variable to control the level of parallelism.
To build the Vulkan ICD library, use Visual Studio 2019 to open the project folder and wait for it to run CMake. Open the CMake Targets View in the Solution Explorer and select the vk_swiftshader project to build it.
The SwiftShader libraries act as drop-in replacements for graphics drivers.
On Windows, most applications can be made to use SwiftShader's DLLs by placing them in the same folder as the executable. On Linux, the
LD_LIBRARY_PATH environment variable or
-rpath linker option can be used to direct applications to search for shared libraries in the indicated directory first.
In general, Vulkan applications look for a shared library named
vulkan-1.dll on Windows (
vulkan-1.so on Linux). This ‘loader’ library then redirects API calls to the actual Installable Client Driver (ICD). SwiftShader's ICD is named
libvk_swiftshader.dll, but it can be renamed to
vulkan-1.dll to be loaded directly by the application. Alternatively, you can set the
VK_ICD_FILENAMES environment variable to the path to
vk_swiftshader_icd.json file that is generated under the build directory (e.g.
.\SwiftShader\build\Windows\vk_swiftshader_icd.json). To learn more about how Vulkan loading works, read the official documentation here.
See CONTRIBUTING.txt for important contributing requirements.
The canonical repository for SwiftShader is hosted at: https://swiftshader.googlesource.com/SwiftShader.
All changes must be reviewed and approved in the Gerrit review tool at: https://swiftshader-review.googlesource.com. You must sign in to this site with a Google Account before changes can be uploaded.
All changes require a Change-ID tag in the commit message. A commit hook may be used to add this tag automatically, and can be found at: https://gerrit-review.googlesource.com/tools/hooks/commit-msg. You can execute
git clone https://swiftshader.googlesource.com/SwiftShader and manually place the commit hook in
SwiftShader/.git/hooks/, or to clone the repository and install the commit hook in one go:
git clone https://swiftshader.googlesource.com/SwiftShader && (cd SwiftShader && git submodule update --init --recursive third_party/git-hooks && ./third_party/git-hooks/install_hooks.sh)
On Windows, this command line requires using the Git Bash Shell.
Changes are uploaded to Gerrit by executing:
git push origin HEAD:refs/for/master
Some tests will automatically be run against the change. Notably, presubmit.sh verifies the change has been formatted using clang-format 11.0.1. Most IDEs come with clang-format support, but may require upgrading/downgrading to the clang-format version 11.0.0 release version (notably Chromium's buildtools has a clang-format binary which can be an in-between revision which produces different formatting results).
SwiftShader's Vulkan implementation can be tested using the dEQP test suite.
See docs/dEQP.md for details.
The third_party directory contains projects which originated outside of SwiftShader:
llvm-subzero contains a minimized set of LLVM dependencies of the Subzero project.
googletest contains the Google Test project, as a Git submodule. It is used for running unit tests for Chromium, and Reactor unit tests. Run
git submodule update --init to obtain/update the code. Any contributions should be made upstream.
Public mailing list: firstname.lastname@example.org
The SwiftShader project is licensed under the Apache License Version 2.0. You can find a copy of it in LICENSE.txt.
Files in the third_party folder are subject to their respective license.
The legal authors for copyright purposes are listed in AUTHORS.txt.
CONTRIBUTORS.txt contains a list of names of individuals who have contributed to SwiftShader. If you‘re not on the list, but you’ve signed the Google CLA and have contributed more than a formatting change, feel free to request to be added.
[^1]: This is not an official Google product.
[^2]: Vulkan 1.3 conformance: https://www.khronos.org/conformance/adopters/conformant-products#submission_717
[^3]: Trademarks are the property of their respective owners.
[^4]: OpenGL ES 3.1 conformance: https://www.khronos.org/conformance/adopters/conformant-products/opengles#submission_906