tree b2e286edd9c15dea5023cb5f300e830c378c5dad
parent 4f495efb55d4dc86a8f9b2aa297f64190b6445c7
author Alexis Hetu <sugoi@google.com> 1664199542 -0400
committer swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com <swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com> 1664207564 +0000

Remove incorrect assert

An assert in Framebuffer::setAttachment() was checking that the
attachment was null before it being assigned, but there is no
such requirement in the Vulkan spec. The assert was removed.

Also fixed an issue where the attachments were set at command
recording time, for some reason, instead of command execution time.

A corresponding issue was logged in VK-GL-CTS:
https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/3999

Tests: dEQP-VK.imageless_framebuffer.*
Bug: b/248611054
Change-Id: Ibd74dce59a315df0cfb25879d9e495f675f4b01c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/68528
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Alexis Hétu <sugoi@google.com>