commit 4126b8ed4d132330b9f5cfb239fff3162773da3a
author Nicolas Capens <capn@google.com> Wed Jul 26 13:34:36 2017 -0400
committer Nicolas Capens <nicolascapens@google.com> Tue Aug 01 17:54:05 2017 +0000
tree 25376006c6b96bc3df1ce74f9d7b4fce0c26f041
parent 1894cfa4e5be9a82491805c2e477f16262717e42

Assume local variables are naturally aligned.

Using alignment = 0 to signify natural alignment will allow to discern
between loads/stores for stack variables, and dereferencing generic
pointers.

Bug swiftshader:78

Change-Id: I6d9c1728fb9858ca57380bc6bfafc7fb2fa5feae
Reviewed-on: https://swiftshader-review.googlesource.com/10968
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

src/Reactor/Reactor.hpp

diff --git a/src/Reactor/Reactor.hpp b/src/Reactor/Reactor.hpp
index 98eb6fd..62d9397 100644
--- a/src/Reactor/Reactor.hpp
+++ b/src/Reactor/Reactor.hpp
@@ -89,8 +89,8 @@
 			return false;
 		}
 
-		Value *loadValue(unsigned int alignment = 0) const;
-		Value *storeValue(Value *value, unsigned int alignment = 0) const;
+		Value *loadValue() const;
+		Value *storeValue(Value *value) const;
 		Value *getAddress(Value *index, bool unsignedIndex) const;
 	};
 
@@ -2105,7 +2105,7 @@
 		template<class S>
 		Pointer(const Pointer<S> &pointer, int alignment = 1) : alignment(alignment)
 		{
-			Value *pointerS = pointer.loadValue(alignment);
+			Value *pointerS = pointer.loadValue();
 			Value *pointerT = Nucleus::createBitCast(pointerS, Nucleus::getPointerType(T::getType()));
 			LValue<Pointer<T>>::storeValue(pointerT);
 		}
@@ -2240,15 +2240,15 @@
 	}
 
 	template<class T>
-	Value *LValue<T>::loadValue(unsigned int alignment) const
+	Value *LValue<T>::loadValue() const
 	{
-		return Nucleus::createLoad(address, T::getType(), false, alignment);
+		return Nucleus::createLoad(address, T::getType(), false, 0);
 	}
 
 	template<class T>
-	Value *LValue<T>::storeValue(Value *value, unsigned int alignment) const
+	Value *LValue<T>::storeValue(Value *value) const
 	{
-		return Nucleus::createStore(value, address, T::getType(), false, alignment);
+		return Nucleus::createStore(value, address, T::getType(), false, 0);
 	}
 
 	template<class T>