tree 9f73b4cd3c21b79d35e0f6202cb56ff81f0cb17b
parent 0d19363b08447955a0d06d5c6c54b7465cadc024
author Nicolas Capens <capn@google.com> 1645766100 -0500
committer Nicolas Capens <nicolascapens@google.com> 1645799625 +0000

Assert llvm::Expected<> don't contain an error

When LLVM_ENABLE_ABI_BREAKING_CHECKS is true, llvm::Expected<> asserts
that we've checked it for errors before using its contained value. This
can be done by invoking its operator bool(), so simply asserting the
object ourselves suffices.

Also make it clearer what type Unwrap() returns.

Bug: b/165000222
Change-Id: I38165ebbd0356fb1ca109963f0b9b2a2415af52a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/63408
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>