tree d18116fa061aa55adbd6b442c17686742caca3ca
parent 5e16bc45a1f7540f697d8f651e023025ee83cdc2
author Nicolas Capens <capn@google.com> 1589397834 -0400
committer Nicolas Capens <nicolascapens@google.com> 1590442907 +0000

Call non-template base methods through 'this' pointer

From https://gcc.gnu.org/onlinedocs/gcc-9.3.0/gcc/Name-lookup.html:
"The C++ standard prescribes that all names that are not dependent on
template parameters are bound to their present definitions when parsing
a template function or class.5 Only names that are dependent are looked
up at the point of instantiation.
...
To make the code valid either use this->f(), or Base<T>::f()"

It is best to use the this->f() solution because it could be a virtual
method.

Also use the type-safe load() and store() methods where possible.

Bug: b/155302798
Change-Id: Id636bfb0b1aae9529bf7f3f58213ec7823d9eddd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45150
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>