)]}'
{
  "commit": "3a56918360284f1329235055d59ff156f576de42",
  "tree": "802d5cdcdbf31bbf523f56b7e779cf85cde0cc50",
  "parents": [
    "ed178a6d7bd5ad8980ac3726c198e3b240a46be0"
  ],
  "author": {
    "name": "Jan Voung",
    "email": "jvoung@chromium.org",
    "time": "Mon Sep 29 10:16:01 2014 -0700"
  },
  "committer": {
    "name": "Jan Voung",
    "email": "jvoung@chromium.org",
    "time": "Mon Sep 29 10:16:01 2014 -0700"
  },
  "message": "Change some explicit type checks into using helper functions.\n\nFor some arithmetic assembler methods, instead of checking\nIceType_i8 || IceType_i1, only allow IceType_i8 and assert if\nan i1 leaked to that stage (should have been vetted earlier\nby the bitcode reader / ABI checks). Could have looked up the\ntype width and isIntegerArithmeticType, etc. in the property table,\nbut that seemed a bit heavy for just checking one type\n(or one of two types).\n\nAlso changed some f32 || f64 checks into just using\nisScalarFloatingType() which looks things up in a property table.\nCould alternatively just keep it as an simple f32 || f64 check,\nand I could change isScalarFloatingType()\u0027s implementation.\n\nIn some places where we assume something is either i32 or i64\nand do a select, change that into using a helper function\nso that we can do one compare, and then assert. Some of the\nasserts are really redundant (already within a branch which\nalready checked that), but hopefully that disappears if\nwe compile in release mode.\nSimilar for f32 or f64 (which happened a lot in the assembler).\n\nBUG\u003dnone\nR\u003dkschimpf@google.com, stichnot@chromium.org\n\nReview URL: https://codereview.chromium.org/613483002\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0ea67b973b14c2b9402568b918a5e9a81be0c6b2",
      "old_mode": 33188,
      "old_path": "src/IceInstX8632.cpp",
      "new_id": "0a2d034f9ac941b6aa424e99590fc5e2b3d84043",
      "new_mode": 33188,
      "new_path": "src/IceInstX8632.cpp"
    },
    {
      "type": "modify",
      "old_id": "cbbcfc93044efe0b4b2f49a0756935f99a32da29",
      "old_mode": 33188,
      "old_path": "src/IceRegistersX8632.h",
      "new_id": "851908c3af7525b13764bcbdc845436cd761d4b7",
      "new_mode": 33188,
      "new_path": "src/IceRegistersX8632.h"
    },
    {
      "type": "modify",
      "old_id": "8a01f00d319c20cb87140906ba7559ee184edadd",
      "old_mode": 33188,
      "old_path": "src/IceTargetLoweringX8632.cpp",
      "new_id": "7a7fb120ab089505c8bc45391c808695212905fa",
      "new_mode": 33188,
      "new_path": "src/IceTargetLoweringX8632.cpp"
    },
    {
      "type": "modify",
      "old_id": "cc782ab59d1c24bdbe59bc9fa6ec5c1503631dce",
      "old_mode": 33188,
      "old_path": "src/IceTypes.h",
      "new_id": "6480c2c57bdb8b52326013f5d53559de20c47ff4",
      "new_mode": 33188,
      "new_path": "src/IceTypes.h"
    },
    {
      "type": "modify",
      "old_id": "9545dc0970f4850a4184fa73f35d3d25c26e7e67",
      "old_mode": 33188,
      "old_path": "src/assembler_ia32.cpp",
      "new_id": "77917096dff4e1790fe3f26ac8b73b0ff87d5e89",
      "new_mode": 33188,
      "new_path": "src/assembler_ia32.cpp"
    },
    {
      "type": "modify",
      "old_id": "5066397e93d978f70912958cf89669861f7fc097",
      "old_mode": 33188,
      "old_path": "src/assembler_ia32.h",
      "new_id": "3e9a93741241b901044a8cc5ff8b465985a0d5d0",
      "new_mode": 33188,
      "new_path": "src/assembler_ia32.h"
    }
  ]
}