tree fd5603e48c710d8fc8a7c6b1ba8de18a973660f0
parent 48c8a180b599c61cf09cb242cff3479b63dbe8c4
author Ben Clayton <bclayton@google.com> 1558625862 +0100
committer Ben Clayton <bclayton@google.com> 1558653442 +0000

ComputeProgram: Don't hold on to the SpirvRoutine.

SpirvRoutine holds reactor fields which must not outlive the scope of the reactor mutex.

While the routine was not directly referenced outside of ComputeProgram::generate(), the destructor of the SpirvRoutine's rr::Variables was touching reactor, leading to data races.

Bug: b/133127573
Change-Id: I854e079efdc0ef2d5b1ae67f014fe7148ad8f892
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31838
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>