Subzero: Clean up some uses of *_cast<>.
Some casts to size_t for use as array indexes are simply unnecessary.
Some explicit declaration types are changed to "auto" to avoid redundancy with the static_cast type.
A few llvm::dyn_cast<> operations are changed to llvm::cast<>, and vice versa.
A few explicit declaration types are changed to "auto" when used with llvm::cast<> and llvm::dynamic_cast<>. Some of these were missed during an earlier cleansing because of multi-line issues.
There are still a few opportunities related to Variable register numbers, but they are ignored for now because they are being addressed in another CL.
BUG= none
R=jpp@chromium.org
Review URL: https://codereview.chromium.org/1674033002 .
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index ed2a907..ed19f61 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -2737,7 +2737,7 @@
appendErrorInstruction(ReturnType);
return;
}
- bool IsTailCall = static_cast<bool>(CCInfo & 1);
+ const bool IsTailCall = (CCInfo & 1);
// Create the call instruction.
Ice::Variable *Dest = (ReturnType == Ice::IceType_void)
