tree 0e6d606dd08ffb58e661e1e27cb0714965ec692c
parent 52c1a859d9ebd3adb49e70d1c7a5ac287388445e
author Eric Holk <eholk@chromium.org> 1517530801 -0800
committer Antonio Maiorano <amaiorano@google.com> 1602772356 +0000

Handle mul instructions with two immediates on x86-32 and x86-64

We were hitting an assert in the assembler due to an instruction that
had not been properly legalized. Now we ensure that mul instructions
take at most one immediate.

It is not clear why these instructions were not removed by upstream
optimizations. This is possibly a result of values only being known at
link time but somehow missed by LTO.

This CL includes some minor cleanup as well:
* Running lit tests does not actually require the Subzero runtime, so
  that is removed from the dependencies list.
* Removes unused capture clauses that were causing warnings treated as
  errors on newer compilers.

Reviewed-on: https://chromium-review.googlesource.com/896962
Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
Reviewed-by: Karl Schimpf <kschimpf@chromium.org>
Signed-off-by: Antonio Maiorano <amaiorano@google.com>

Bug: b/120208871
Change-Id: Ibf33b6961ee99311ca18c7179c56df28af6faf17
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/49068
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>