Track undefined sym in the symtab. Remove hack for missing relocs against undef.
Preliminary linking tests, seems to show that the linker
and objcopy are happy to use 'em on spec2k, and the
result runs! (Had to be careful to clobber the old .s
and .o files to make it's testing the right copy).
Haven't tried crosstests yet.
BUG=none
R=stichnot@chromium.org
Review URL: https://codereview.chromium.org/889613004
diff --git a/src/IceELFSection.cpp b/src/IceELFSection.cpp
index f6fb526..f2e129d 100644
--- a/src/IceELFSection.cpp
+++ b/src/IceELFSection.cpp
@@ -74,18 +74,8 @@
}
}
-size_t ELFRelocationSection::getSectionDataSize(
- const GlobalContext &Ctx, const ELFSymbolTableSection *SymTab) const {
- size_t NumWriteableRelocs = 0;
- for (const AssemblerFixup &Fixup : Fixups) {
- const ELFSym *Symbol = SymTab->findSymbol(Fixup.symbol(&Ctx));
- // TODO(jvoung): When the symbol table finally tracks everything,
- // just use the Fixups.size() as the count, and remove the
- // SymTab and Ctx params.
- if (Symbol)
- ++NumWriteableRelocs;
- }
- return NumWriteableRelocs * Header.sh_entsize;
+size_t ELFRelocationSection::getSectionDataSize() const {
+ return Fixups.size() * Header.sh_entsize;
}
// Symbol tables.
