tree 93988107a402778ae3b2ddeb93140ff3ddff0341
parent 88e698a4f3e35f509ac80d9ffed8a4e0bbe3a85a
author Nicolas Capens <capn@google.com> 1605938455 -0500
committer Nicolas Capens <nicolascapens@google.com> 1606162156 +0000

Limit the recursion depth of llvm::SelectionDAG::isSplatValue()

This method previously always recursively checked both the left-hand
side and right-hand side of binary operations for splatted (broadcast)
values to determine if the parent DAG node is a splat. For chained
operations, such as the 10,000 adds of the dEQP-VK.spirv_assembly.
instruction.graphics.spirv_ids_abuse.lots_ids_frag/vert tests,
very deep recursion could result in stack overflow.

Like several other SelectionDAG methods, limit the recursion depth to
MaxRecursionDepth (6).

Bug: b/173785481
Change-Id: I22ee0453db7cf1311267291a331ad8fa3b57b1d9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/50672
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Jason Macnak <natsu@google.com>