commit 24021a2d7ea512bdd9012d53b0fa56849e503bd1
author Ben Clayton <headlessclayton@gmail.com> Tue Feb 19 11:42:31 2019 +0000
committer Ben Clayton <bclayton@google.com> Tue Feb 19 16:08:50 2019 +0000
tree e85420484d0532f1f025660641b75adb725eba88
parent 6d74ab852bf2cbada5b3f7cd07402f72d01c45f4

vkCmdBlitImage: Make a copy of the VkImageBlit structure

Don't hold a pointer to the structure - there's no guarantees it'll still be vaild by command buffer execution time.

Fixes flakiness of the dEQP-VK.memory.pipeline_barrier.transfer_dst_storage_image.* tests

Bug: b/124729778
Change-Id: I747512b1a34c5d4d7dff227b15b08c69d07b298d
Reviewed-on: https://swiftshader-review.googlesource.com/c/25008
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

src/Vulkan/VkCommandBuffer.cpp

diff --git a/src/Vulkan/VkCommandBuffer.cpp b/src/Vulkan/VkCommandBuffer.cpp
index b3bca2f..6c217dd 100644
--- a/src/Vulkan/VkCommandBuffer.cpp
+++ b/src/Vulkan/VkCommandBuffer.cpp
@@ -357,7 +357,7 @@
 private:
 	VkImage srcImage;
 	VkImage dstImage;
-	const VkImageBlit& region;
+	VkImageBlit region;
 	VkFilter filter;
 };