commit 1e3222332c963efe4dfeedbd014abbeb2e88e919
author Hernan Liatis <hliatis@google.com> Fri May 17 11:53:44 2019 -0700
committer Hernan Liatis <hliatis@google.com> Fri May 17 22:30:43 2019 +0000
tree a0681cbbe6ee48dd6b0969bc0328ef9a07be9519
parent 94e3e4ac3769a1c50968fa4c847672724a5c601d

Fix mismatched alloc/free in Swapchain

The swapchain images were being freed with an allocator
despite never being created with one.

Tests: dEQP-VK.wsi.xlib.swapchain.simulate_oom.*
Bug: b/132451407
Change-Id: I26c6ecd18d04f514cdae171100de6a89c919a777
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31692
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Hernan Liatis <hliatis@google.com>

src/WSI/VkSwapchainKHR.cpp

diff --git a/src/WSI/VkSwapchainKHR.cpp b/src/WSI/VkSwapchainKHR.cpp
index 672be09..30c72a9 100644
--- a/src/WSI/VkSwapchainKHR.cpp
+++ b/src/WSI/VkSwapchainKHR.cpp
@@ -38,8 +38,8 @@
 		if (currentImage.imageStatus != NONEXISTENT)
 		{
 			vk::Cast(createInfo.surface)->detachImage(&currentImage);
-			vk::destroy(currentImage.imageMemory, pAllocator);
-			vk::destroy(currentImage.image, pAllocator);
+			vk::destroy(currentImage.imageMemory, nullptr);
+			vk::destroy(currentImage.image, nullptr);
 
 			currentImage.imageStatus = NONEXISTENT;
 		}