tree 96079ec893f1a766eaf36728effc034fcd098fc2
parent f3692067e3eef16db9b02919fe159c5cfdd056b5
author Nicolas Capens <capn@google.com> 1637646022 -0500
committer Nicolas Capens <nicolascapens@google.com> 1637784434 +0000

Assert that casting memory sizes to 32-bit doesn't overflow

VkPhysicalDeviceMaintenance3Properties::maxMemoryAllocationSize is
currently 1 GiB. This ensures that the memory of all resources can be
addressed using 32-bit indices. We return VK_ERROR_OUT_OF_DEVICE_MEMORY
when this limit is exceeded, but it's still best to ensure we don't
inadvertently end up calculating sizes larger than 4 GiB that would
cause arithmetic overflow due to casting to 32-bit integers.

Bug: b/200806413
Change-Id: I10e828a93d6c24624f049a0809f0b962d473f44f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/60068
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Sean Risser <srisser@google.com>