| commit | 1ca6698b903cab2091dd41a81d8fc4a445e378ff | [log] [tgz] |
|---|---|---|
| author | Nicolas Capens <capn@google.com> | Wed May 04 17:19:46 2022 -0400 |
| committer | Nicolas Capens <nicolascapens@google.com> | Sat May 07 03:58:17 2022 +0000 |
| tree | 0c413a412e22bccb96c02636b5464b976603de81 | |
| parent | 74e34ab97aeb2a6b68d52a9e0112968b33b509ea [diff] |
Don't make use of cvtps2dq in MSan builds MemorySanitizer's instrumentation currently does not handle the cvtps2dq intrinsic/instruction. It falls back to checking the source operand for any uninitialized data. In shaders we can have conditional code which causes only some SIMD lanes to be initialized, and only those lanes are logically used in further computations. So it's valid in these cases to do operations that use cvtps2dq on a partially initialized vector, but MSan will report it as an error. This can be worked around by avoiding the use of cvtps2dq and instead relying on lowerRoundInt(), which translates into the nearbyint intrinsic followed by an FPToSI. MemorySanitizer handles the former in the maybeHandleSimpleNomemIntrinsic() method, which copies the shadow of the source vector to the destination vector (i.e. it propagates it without checking it). Note that cvtps2dq does not follow the same code path as nearbyint because it has different types for the source and destination vector. We could handle it explicitly by doing the same shadow propagation. Considering that the workaround in Reactor results in simply using two cheap instructions instead of one it's not performance critical to fix this in LLVM. The rr::RoundIntClamped() intrinsic required a fix in the fallback path: 0x80000000 was meant to represent -2147483648 but instead got casted to a positive float value of 2147483648.0f. Explicitly casting it to int first produces the desired negative integer value before the conversion to float. Bug: b/172238865 Change-Id: I4f07bb8cb6d25d914dab836f64510f8b2bad18ba Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/65608 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com>
SwiftShader is a high-performance CPU-based implementation of the Vulkan graphics API12. Its goal is to provide hardware independence for advanced 3D graphics.
NOTE: The ANGLE project can be used to achieve a layered implementation of OpenGL ES (aka. “SwANGLE”).
SwiftShader libraries can be built for Windows, Linux, and macOS.
Android and Chrome (OS) build environments are also supported.
CMake
Install CMake for Linux, macOS, or Windows and use either the GUI or run the following terminal commands:
cd build cmake .. cmake --build . --parallel ./vk-unittests
Tip: Set the CMAKE_BUILD_PARALLEL_LEVEL environment variable to control the level of parallelism.
Visual Studio
To build the Vulkan ICD library, use Visual Studio 2019 to open the project folder and wait for it to run CMake. Open the CMake Targets View in the Solution Explorer and select the vk_swiftshader project to build it.
The SwiftShader libraries act as drop-in replacements for graphics drivers.
On Windows, most applications can be made to use SwiftShader's DLLs by placing them in the same folder as the executable. On Linux, the LD_LIBRARY_PATH environment variable or -rpath linker option can be used to direct applications to search for shared libraries in the indicated directory first.
In general, Vulkan applications look for a shared library named vulkan-1.dll on Windows (vulkan-1.so on Linux). This ‘loader’ library then redirects API calls to the actual Installable Client Driver (ICD). SwiftShader's ICD is named libvk_swiftshader.dll, but it can be renamed to vulkan-1.dll to be loaded directly by the application. Alternatively, you can set the VK_ICD_FILENAMES environment variable to the path to vk_swiftshader_icd.json file that is generated under the build directory (e.g. .\SwiftShader\build\Windows\vk_swiftshader_icd.json). To learn more about how Vulkan loading works, read the official documentation here.
See CONTRIBUTING.txt for important contributing requirements.
The canonical repository for SwiftShader is hosted at: https://swiftshader.googlesource.com/SwiftShader.
All changes must be reviewed and approved in the Gerrit review tool at: https://swiftshader-review.googlesource.com. You must sign in to this site with a Google Account before changes can be uploaded.
Next, authenticate your account here: https://swiftshader-review.googlesource.com/new-password (use the same e-mail address as the one configured as the Git commit author).
All changes require a Change-ID tag in the commit message. A commit hook may be used to add this tag automatically, and can be found at: https://gerrit-review.googlesource.com/tools/hooks/commit-msg. You can execute git clone https://swiftshader.googlesource.com/SwiftShader and manually place the commit hook in SwiftShader/.git/hooks/, or to clone the repository and install the commit hook in one go:
git clone https://swiftshader.googlesource.com/SwiftShader && (cd SwiftShader && git submodule update --init --recursive third_party/git-hooks && ./third_party/git-hooks/install_hooks.sh)
On Windows, this command line requires using the Git Bash Shell.
Changes are uploaded to Gerrit by executing:
git push origin HEAD:refs/for/master
When ready, add a project owner as a reviewer on your change.
Some tests will automatically be run against the change. Notably, presubmit.sh verifies the change has been formatted using clang-format 11.0.1. Most IDEs come with clang-format support, but may require upgrading/downgrading to the clang-format version 11.0.0 release version (notably Chromium's buildtools has a clang-format binary which can be an in-between revision which produces different formatting results).
SwiftShader's Vulkan implementation can be tested using the dEQP test suite.
See docs/dEQP.md for details.
The third_party directory contains projects which originated outside of SwiftShader:
subzero contains a fork of the Subzero project. It originates from Google Chrome‘s (Portable) Native Client project. The fork was made using git-subtree to include all of Subzero’s history.
llvm-subzero contains a minimized set of LLVM dependencies of the Subzero project.
PowerVR_SDK contains a subset of the PowerVR Graphics Native SDK for running several sample applications.
googletest contains the Google Test project, as a Git submodule. It is used for running unit tests for Chromium, and Reactor unit tests. Run git submodule update --init to obtain/update the code. Any contributions should be made upstream.
See docs/Index.md.
Public mailing list: swiftshader@googlegroups.com
General bug tracker: https://g.co/swiftshaderbugs
Chrome specific bugs: https://bugs.chromium.org/p/swiftshader
The SwiftShader project is licensed under the Apache License Version 2.0. You can find a copy of it in LICENSE.txt.
Files in the third_party folder are subject to their respective license.
The legal authors for copyright purposes are listed in AUTHORS.txt.
CONTRIBUTORS.txt contains a list of names of individuals who have contributed to SwiftShader. If you‘re not on the list, but you’ve signed the Google CLA and have contributed more than a formatting change, feel free to request to be added.