tree 66ec1893f9bbbcc6fb34ff8f5195d5d6cbaa00b9
parent d8fb3d33f38258b7fb177bd4cb420fab2e0c2c3a
author Karl Schimpf <kschimpf@google.com> 1429217443 -0700
committer Karl Schimpf <kschimpf@google.com> 1429217443 -0700

Fix locking for printing error messages.

The method TopLevelParser::ErrorAt applies a lock to print the error
message. Unfortunately, it keeps the lock longer than necessary,
resulting in deadlock (on following fatal message) if error recovery
is not allowed.

Fixed by limiting scope of lock to only apply to the printing of the
error message.

Modified ClFlags to allow a "reset", and made ClFlags modifiable
by bitcode munge tests. This allowed us to test this problem as
a unit test.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4138
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/1091023002