tree 39b2c167b4c4ba17196f8d52471941aa29164f2e
parent c57ec6f0af339ba3af1debdf17aee2cc0b115362
author Nicolas Capens <capn@google.com> 1556847475 -0400
committer Chris Forbes <chrisforbes@google.com> 1556851768 +0000

Fix overwriting of filter factor

The third coordinate of the 2D sampling code is only used for 2D array
textures, so we don't compute a filter factor. This used to be taken
advantage of by passing the filter factor of the second coordinate to
the addressing method for the third coordinate, and ensuring that the
addressing mode of this component was ADDRESSING_LAYER even for non-
array textures.

Instead of relying on this brittle hack, just specify a third filter
factor. Now that we elide materialization of single-block variables,
this doesn't take any stack space and is zero overhead to the backend.

Bug: b/129523279
Change-Id: Iee6b0f90bf1cc4ccc41672d3bdb706ff5af0a555
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30548
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>