tree e926cade569eef6d508e19998d600c6efd985a28
parent 518056981519733acd0a5b28efcfa6e33733a2f0
author Nicolas Capens <capn@google.com> 1629862268 -0400
committer Nicolas Capens <nicolascapens@google.com> 1630014129 +0000

Refactor determining the aspects to clear

This change uses additive logic for determining which aspects to clear,
to improve readability and avoid future bugs in case more aspects can
be cleared during `VK_ATTACHMENT_LOAD_OP_CLEAR` execution.

Note that previously, if present, aspect bits other than COLOR, DEPTH,
and STENCIL would have been preserved. However, the Vulkan spec
explicitly disallows METADATA and MEMORY_PLANE_i aspect bits for
attachments, and PLANE_i would make no sense since multi-planar images
have different sizes of planes, so there's no single set of components
for each pixel to render to if it was used by an attachment, with the
possible exception of 444 formats. SwiftShader doesn't support 444
multi-planar formats though, and implementations that do, don't set the
COLOR_ATTACHMENT feature bit (nor on any other multi-planar format for
that matter). In addition, we have asserts in Image::clear() that check
that only COLOR, DEPTH, and/or STENCIL aspects are cleared. So this is
still a pure refactoring.

An additional assert was added to a missing else clause, for good
measure.

Fixes: b/197695836
Change-Id: I4eb4ba41863e21b028b33c4e4361390cf169e815
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/56629
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>