commit 04f41257e7a3060bceebf6dbe308add632c4d253
author Nicolas Capens <capn@google.com> Tue May 02 15:14:58 2017 -0400
committer Nicolas Capens <capn@google.com> Fri May 05 15:17:17 2017 +0000
tree da6c113a7bc836d0569ca3b16d0379f829d6da0d
parent 0f20653759521be0e9a87579104ce04834495305

Don't needlessly generate cursor drawing code.

Direct3D 9 provides support for a "hardware" cursor. There is no such thing
in newer APIs, so we shouldn't waste time dynamically generating code for it.

Change-Id: I8d54c3500966ce075afb83c98c5013024062eed8
Reviewed-on: https://swiftshader-review.googlesource.com/9629
Reviewed-by: Corentin Wallez <cwallez@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>
Tested-by: Nicolas Capens <capn@google.com>

src/Main/FrameBuffer.cpp

diff --git a/src/Main/FrameBuffer.cpp b/src/Main/FrameBuffer.cpp
index d161c1f..ebfebed 100644
--- a/src/Main/FrameBuffer.cpp
+++ b/src/Main/FrameBuffer.cpp
@@ -33,7 +33,7 @@
 {
 	extern bool forceWindowed;
 
-	FrameBuffer::Cursor FrameBuffer::cursor = {0};
+	FrameBuffer::Cursor FrameBuffer::cursor = {};
 	bool FrameBuffer::topLeftOrigin = false;
 	void FrameBuffer::typeinfo() {}
 
@@ -531,31 +531,34 @@
 				}
 			}
 
-			Int x0 = *Pointer<Int>(cursor + OFFSET(Cursor,x));
-			Int y0 = *Pointer<Int>(cursor + OFFSET(Cursor,y));
-
-			For(Int y1 = 0, y1 < state.cursorHeight, y1++)
+			if(state.cursorWidth > 0 && state.cursorHeight > 0)
 			{
-				Int y = y0 + y1;
+				Int x0 = *Pointer<Int>(cursor + OFFSET(Cursor,x));
+				Int y0 = *Pointer<Int>(cursor + OFFSET(Cursor,y));
 
-				If(y >= 0 && y < height)
+				For(Int y1 = 0, y1 < state.cursorHeight, y1++)
 				{
-					Pointer<Byte> d = dst + y * dStride + x0 * dBytes;
-					Pointer<Byte> s = src + y * sStride + x0 * sBytes;
-					Pointer<Byte> c = *Pointer<Pointer<Byte>>(cursor + OFFSET(Cursor,image)) + y1 * state.cursorWidth * 4;
+					Int y = y0 + y1;
 
-					For(Int x1 = 0, x1 < state.cursorWidth, x1++)
+					If(y >= 0 && y < height)
 					{
-						Int x = x0 + x1;
+						Pointer<Byte> d = dst + y * dStride + x0 * dBytes;
+						Pointer<Byte> s = src + y * sStride + x0 * sBytes;
+						Pointer<Byte> c = *Pointer<Pointer<Byte>>(cursor + OFFSET(Cursor,image)) + y1 * state.cursorWidth * 4;
 
-						If(x >= 0 && x < width)
+						For(Int x1 = 0, x1 < state.cursorWidth, x1++)
 						{
-							blend(state, d, s, c);
-						}
+							Int x = x0 + x1;
 
-						c += 4;
-						s += sBytes;
-						d += dBytes;
+							If(x >= 0 && x < width)
+							{
+								blend(state, d, s, c);
+							}
+
+							c += 4;
+							s += sBytes;
+							d += dBytes;
+						}
 					}
 				}
 			}