tree 55eb6b993ff2b370a377547842e88f06bb142695
parent 8c181d7d11654ef9e3002dc4f3a2105d563b6364
author Nicolas Capens <capn@google.com> 1633457445 -0400
committer Nicolas Capens <nicolascapens@google.com> 1633543125 +0000

Separate device memory allocations from host allocations

vk::allocate() was previously used for Vulkan object allocation,
internal 'host' memory allocations, and 'device' memory allocations. The
`DEVICE_MEMORY` constant was intended to help separate the latter from
the former two, but was being used for various host memory allocations.

Host memory allocations should all call the allocation callbacks
provided by the application, if any. To make it clearer where we're
currently not providing these callbacks, `DEVICE_MEMORY` has been
replaced by `NULL_ALLOCATION_CALLBACKS`. For true device memory
allocations, vk::allocateDeviceMemory() was added.

Note that this change does not alter the underlying sw::allocate*() call
used for either host or device memory allocations. Both still use zero-
initialized memory at this point.

Bug: b/140991626
Change-Id: I4224ad2597248af3dd8a5311da61361b434f32c3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/57708
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>