tree acc769e6d47007e2f8d66bba136dbfaf971a87b8
parent fdf41479349bfc6f860ee94090382051e35107e6
author Nicolas Capens <capn@google.com> 1664991116 -0400
committer Nicolas Capens <nicolascapens@google.com> 1666190299 +0000

Limit SPIR-V phi variable lifetimes

This change moves phi variables from SpirvRoutine to EmitState. The
former class represents the interface of a shader, and phis are not part
of that. EmitState only lives during emission of the actual SPIR-V code
into Reactor code, so it deletes these variables automatically and
prevents unnecessary materialization and reduces compilation overhead.

This also enabled reducing the public interface of EmitState to a single
static emit() function.

Bug: b/178662288
Bug: b/247020580
Change-Id: I88110c02e925699ad9706aaa3dc8779f9bbd3430
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/68729
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>